Pgtk childframe support

masm11 / emacs

Mirror of GNU Emacs

http://www.gnu.org/software/emacs/

GNU General Public License v3.0

198 stars 14 forks source link

Closed fejfighter closed 4 years ago

fejfighter commented 4 years ago

GTK3 (and 4) use a "popup" window type that can only be set at GtkWindow creation.

This appears to work for X11, Wayland and Broadway, but is a little buggy on Xwayland.

I use this with the posframe libraries, mostly ivy-posframe and company-posframe

declantsien commented 4 years ago

Is this PR abandoned? Just tried it, the child-frame(posframe) worked fine. I've tried ivy-posframe emacs-rime.

masm11 commented 4 years ago

@fejfighter, could you resolve conflicts?

fejfighter commented 4 years ago

@declanqian I put up a few at once and wanted to get #14 in first

@masm11 yeah, give me a couple of hours, and I'll get this updated and verified

fejfighter commented 4 years ago

@masm11 Conflicts should be fixed now and I think that is #12 covered for now, but we could keep it up to track other features

@declanqian feel free to test

declantsien commented 4 years ago

Yeah. It works fine here. As far as I can tell. Nice work. @fejfighter

masm11 commented 4 years ago

Thank you!