masm11 / emacs

Mirror of GNU Emacs
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
198 stars 14 forks source link

Fix migrating Child frames #26

Closed fejfighter closed 4 years ago

fejfighter commented 4 years ago
fejfighter commented 4 years ago

I already have this in the upstream candidate but this should pull straight in.

there was a little bit of miscalculation for the child frame position in emacs v gtk

this should handle that better.


On the Copyright side of things, I have signed and sent in my form. It's with the FSF. I did initially send it to the wrong account so it has been delayed. hopefully that will be processed and the branch can be created on fsf/gnu savannah

masm11 commented 4 years ago

Thanks, but it's not in GNU coding style, e.g. this code:

      if (xoff < 0) {
    f->size_hint_flags |= XNegative;
      }

should be:

     if (xoff < 0)
       {
         f->size_hint_flags |= XNegative;
       }

Chould you fix that?

masm11 commented 4 years ago

On the Copyright side of things, I have signed and sent in my form. It's with the FSF. I did initially send it to the wrong account so it has been delayed. hopefully that will be processed and the branch can be created on fsf/gnu savannah

OK. FSF's processing may takes one or two weeks. Please wait for the form signed by fsf, and if you receive it, then please let me know.

fejfighter commented 4 years ago

Thanks, but it's not in GNU coding style, e.g. this code:

      if (xoff < 0) {
  f->size_hint_flags |= XNegative;
      }

should be:

     if (xoff < 0)
       {
         f->size_hint_flags |= XNegative;
       }

Chould you fix that?

Yeah, fixed.

hard to break old habits for braces, but that is the standard

masm11 commented 4 years ago

Thank you!