Closed kira-bruneau closed 3 years ago
Thanks for the hard debugging.
I'm going to push pgtk fork to fsf's repository. To do that, we need to do paperwork for copyright assignment. I have done it. Have you done the paperwork?
can't you use TINYCHANGE to get around the copyright issue?
On 10/15/20 12:40 PM, Yuuki Harano wrote:
EXTERNAL EMAIL: Treat content with extra caution.
Thanks for the hard debugging.
I'm going to push pgtk fork to fsf's repository. To do that, we need to do paperwork for copyright assignment. I have done it. Have you done the paperwork?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/masm11/emacs/pull/70#issuecomment-709448752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACY6NGULF5ZHC76OP7WUB3SK4QWVANCNFSM4SREXBYQ.
@masm11 No, I haven't done the paperwork for copyright assignment, but it looks like I can just add (tiny change)
to the commit message like @titaniumbones mentioned. https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html.
I will do that now.
I also just updated the commit to use my full name rather than my username.
thanks!
Using the pgtk build I noticed that any command that tried to launch a new Emacs process using
invocation-name
would fail.For example with
async-start
:I found that
invocation-name
was set toemacs-28-0-50
, when it should have been set toemacs-28.0.50
. After a lot of debugging I found that it was being modified inlisp/term/pgtk-win.el
when it should have been copied like it is inlisp/term/x-win.el
.This change just wraps
invocation-name
withcopy-sequence
like inlisp/term/x-win.el
to avoid mutating the global variable.