masm11 / emacs

Mirror of GNU Emacs
http://www.gnu.org/software/emacs/
GNU General Public License v3.0
198 stars 14 forks source link

PGTK makes emacs subject to GTK/GDK scaling breaking some ui elements #89

Closed Thaodan closed 3 years ago

Thaodan commented 3 years ago

When using Emacs with feature/pgtk, it is subject to the DPI scaling of GTK/GDK. This can break come UI elements.

I noticed the following ui elements broke:

Screenshot_20201222_054349

masm11 commented 3 years ago

a

No problem. Could you tell me how to reproduce?

Thaodan commented 3 years ago

Use emacs in --daemon mode with this unit:

[Unit]
Description=Emacs: the extensible, self-documenting text editor
Wants=graphical.target
Wants=environment.target

[Service]
Type=forking
ExecStart=/usr/bin/emacs --daemon
ExecStop=/usr/bin/emacsclient --eval "(kill-emacs)"
Environment=SSH_AUTH_SOCK=%t/keyring/ssh
Environment=GDK_SCALE=2
#Environment=GDK_DPI_SCALE=0.5
Restart=always
TimeoutStartSec=0
[Install]
WantedBy=default.target

# /home/bidar/.config/systemd/user/emacs.service.d/override.conf
[Service]
TimeoutStopSec=600

Then use modeline icons mode together with simple-modeline and powerline as theme.

masm11 commented 3 years ago

modeline icons mode

What is this? Is it contained in powerline or simple-modeline?

Thaodan commented 3 years ago

https://github.com/ryuslash/mode-icons

masm11 commented 3 years ago

Thanks, but your issue does not reproduce.

a2

What DE/WM are you using?

Thaodan commented 3 years ago

Do you use high dpi scaling?

For normal 1.0 scaling everything is fine.

masm11 commented 3 years ago

I use this config in wayfire:

scale = 1.50000

and this config in given emacs.service:

Environment=GDK_SCALE=2

and normal.

Thaodan commented 3 years ago

The error was on my side, I was using an old version of mode-icons-mode that was buggy this fix was missing:

https://github.com/ryuslash/mode-icons/commit/ e29ab2899226c0c2afe00d774de541d1534d0cf7

Closing