masmerise / livewire-toaster

Beautiful toast notifications for Laravel / Livewire.
MIT License
374 stars 22 forks source link

Add middle alignment #9

Closed aldozumaran closed 1 year ago

mabdullahsari commented 1 year ago

Hey, thanks for your PR. 👋

Though, I'm wondering... Why would you need to be able to vertically center toast messages? It's such an odd space to utilize, especially on mobile devices. I have yet to see a toast library that does this. Could you provide a real-world example / explanation? Thanks!

aldozumaran commented 1 year ago

I would like to use toast as a warning message (centered), in this way it is more visible to the user (validation error, server error)

mobile example: image

mabdullahsari commented 1 year ago

Please update the README with the new configuration when you're done.

aldozumaran commented 1 year ago

done! thanks

mabdullahsari commented 1 year ago

Please update the data provider of the ToasterHubTest to include Alignment::Middle as well.

PS: Don't miss the change requests above 😉

aldozumaran commented 1 year ago

done

mabdullahsari commented 1 year ago

done

You forgot to adjust the comment in the configuration file & README.

aldozumaran commented 1 year ago

sorry! updated!

mabdullahsari commented 1 year ago

Thanks. I'll verify if the default animation looks good with the middle alignment.

mabdullahsari commented 1 year ago

Thanks for your contribution. Released as 1.2.0