masmu / pulseaudio-dlna

A lightweight streaming server which brings DLNA / UPNP and Chromecast support to PulseAudio and Linux
GNU General Public License v3.0
1.25k stars 161 forks source link

url without colon, Ubuntu 18.04 #410

Open msalat opened 3 years ago

msalat commented 3 years ago

I'm using the "examples/advanced_examples/dlna" (sink) example of esp-adf, I'm getting an error because of a missing colon (port number) sent somewhere (this is perhaps more a compatibility bug on esp-adf).

Here my changes to get things work:

/usr/lib/python2.7/dist-packages/pulseaudio_dlna/plugins/upnp$ diff -c renderer.py{,.ori000}
*** renderer.py 2020-10-13 19:36:05.800160382 +0200
--- renderer.py.ori000  2020-10-13 19:27:14.553334886 +0200
***************
*** 525,534 ****

          def process_xml(url, xml_root, xml, type_):
              url_object = urlparse.urlparse(url)
!             print("MODIFIED plugins/upnp/renderer.py")
!             # ip, port = url_object.netloc.split(':')
!             ip = url_object.netloc
!             port = 80
              services = []
              for device in xml_root.findall('.//{*}device'):
                  device_type = device.find('{*}deviceType')
--- 525,531 ----

          def process_xml(url, xml_root, xml, type_):
              url_object = urlparse.urlparse(url)
!             ip, port = url_object.netloc.split(':')
              services = []
              for device in xml_root.findall('.//{*}device'):
                  device_type = device.find('{*}deviceType')