search

masneyb / gftp

gFTP is a free multithreaded file transfer client for *NIX based machines. 56 language translations available.
http://www.gftp.org
MIT License
116 stars 21 forks source link

Convert xpm to png #157

Closed sedwards closed 1 year ago

sedwards commented 1 year ago
sedwards commented 1 year ago

Hi Brian, it's been a LOOONG time. Hope you are doing well.

Just ignore this one for a bit,I forgot to check from our discussion around issue #93 and saw your attachment with the better icons and my old screenshot. Allow me to go back and revisit it and then I will amend this PR and convert back from a draft.

sedwards commented 1 year ago

OK, so I've decided to break this work in to two parts. This first is just to remove the usage of xpm (while leaving the functionality there so as to not break upgrades). The second part later will be to see if there is a way we could use a gtk/gnome theme and load the proper icons from there that can match.

If you want to merge this that's cool, otherwise, I'll just leave it on my fork until a later date. I'm going to come back to it after I look at some more clean-up and an idea I had to try to support gtk3/gtk4.

wdlkmpx commented 1 year ago

The reason the transition to png did not happen a while ago was because the port to pure gtk2 was not finished, there's still gtk1 code in the transfer window stuff, a.k.a GtkCTree

It has been a WIP since 2020 I guess, I was thinking of redesigning stuff, but I got stuck https://github.com/masneyb/gftp/tree/gtktreeview https://github.com/masneyb/gftp/commit/14493751afa45ec41ada1533fefadf9a02e5d11b

GtkCTree only supports .xpm icons, so it will still probably work with gtk2 with warnings about incompatible type and missing icons in the transfer window. But it will not compile with gtk3, all gtk transfer stuff must be disabled

sedwards commented 1 year ago

That makes sense. OK we can close this out, I just am leaving it open as draft for a few days so you can see my reply.

In the meantime, I am going to take a peak at your progress and apply to my current GTK3 and GTK4 build fixes branches in my fork. I've been slowly nibbling around the edges at getting to build as cleanly as possible against all libraries without fixing the clist/ctree transfer window issue but there is no more avoid it.

sedwards commented 1 year ago

Closing this out until we are ready to make gtk3.0 the default for builds, then we can look at migrating everything to *.png resources and work out some backward compatibility hack for gtk 2.x builds