search

masneyb / gftp

gFTP is a free multithreaded file transfer client for *NIX based machines. 56 language translations available.
http://www.gftp.org
MIT License
116 stars 21 forks source link

- Remove Translators as separate tab from Authors #169

Closed sedwards closed 1 year ago

sedwards commented 1 year ago

This only works on gtk2 and isn't really possibly to implement unless we parse AUTHORS and split it up, which again only is useful on gtk2.x.

Treat all Translators as Authors.

wdlkmpx commented 1 year ago

It also works with gtk3, after generating zh_TW locale # LANG=zh_TW.UTF-8 src/gtk/gftp-gtk

I can't provide a screenshot, but I see extra text at the end: complex symbols, linuxhall, Kevin Tse, Abel Cheung, Chun-Li, Yi Long Musk

sedwards commented 1 year ago

OK so you are saying it shows up for you when you run in a different language/locale but not be default right?

Because on GTK3 I don't get a separate tab or anything at all. But if it does show up in the other locales that makes sense I guess, but we still need a way to populate it with the Translators sections from the AUTHORS file.

Honestly, I'd propose just getting rid of it and keeping the Credits with the AUTHORS file rather than doing the extra work. Translators get the same credit as AUTHORS as everyone else, and then we don't need a special patch for that case. translator-missing

wdlkmpx commented 1 year ago

That looks pretty bad, Gtk2 does a better job. But you have to scroll to the end, and you'll see something like this:

Screenshot(1)

I'd move the translator credits to their respective .po files, I'll probably do that.