search

masneyb / gftp

gFTP is a free multithreaded file transfer client for *NIX based machines. 56 language translations available.
http://www.gftp.org
MIT License
116 stars 21 forks source link

Replace instance of gtk_container_add with gtk_box_pack_start #171

Closed sedwards closed 1 year ago

sedwards commented 1 year ago

Replace instance of gtk_container_add with gtk_box_pack_start for compatibility with gtk2/3/4

sedwards commented 1 year ago

This one actually seems a little buggy after more testing, but honestly, the entire booksmarks code is a little buggy and maybe needs a complete rewrite for gtk3/4.

If you don't like it close it out. It still works for me in my testing with gtk2, but I am seeing

(gftp-gtk:165097): Gdk-CRITICAL **: 13:50:04.656: IA__gdk_window_get_window_type: assertion 'GDK_IS_WINDOW (window)' failed
(gftp-gtk:165097): Gtk-CRITICAL **: 13:50:19.283: gtk_box_pack: assertion 'GTK_IS_BOX (box)' failed

In my logs that may be cause by this and I don't know why even though the code is working.