booksmarks - Gtk2/3/4 Compatibility fixes

masneyb / gftp

gFTP is a free multithreaded file transfer client for *NIX based machines. 56 language translations available.

http://www.gftp.org

MIT License

118 stars 21 forks source link

booksmarks - Gtk2/3/4 Compatibility fixes #172

Closed sedwards closed 1 year ago

sedwards commented 1 year ago

- Compatiblity fix, replace call to gtk_container_add with gtk_scrolled_window_add_with_viewport
noting that gtk_scrolled_window_set_child will be used in gtk4
- Replace two calls of gtk_container_add with gtk_button_set_image
for compatiblity with gtk2/3/(mostly)4

sedwards commented 1 year ago

Various changes and commits merged.

wdlkmpx commented 1 year ago

Can't test ATM since the PC keyboard is damaged, but I'll comment

sedwards commented 1 year ago

I found a bug in one of my PRs, so I retested, dropped that PR and merged the rest. GTK 2/3/4 compatibility will be hard, maybe even impossible, but its a worthy goal to reuse what we can if we ever hope to support GTK4/5 so I wanted to clean up what I could.

sedwards commented 1 year ago

For some reason, Github didn't update the PR, I am closing and reopening with the correct pull and diff