Vendors added and Readme added with proper licensing

masnun / php-lang

The repository for php-lang.net - the source for PHP content mashup

0 stars 1 forks source link

Vendors added and Readme added with proper licensing #1

Closed shahariaazam closed 11 years ago

shahariaazam commented 11 years ago

Few vendor package added and readme.md file added with proper licensing information of this project.

masnun commented 11 years ago

Please don't add the vendor directory. We can grab them just by running composer install or php composer.phar install. It is common practice to exclude the vendor directory and include just composer.json and composer.lock files so that composer can install the same set of dependencies on all setups.
I already added a test command which I was using to test the data sources. The command for scraping should be named scrape instead of scrap
Thanks for adding the License.

shahariaazam commented 11 years ago

I got your point. Thanks... Ok. So now I am gonna work on scrape command. \ In the vendors directory there is a autoloader. if we skip that project will not run. So we have to mention it in our read me that to run this project everybody must run composer to get the dependencies. Right?

masnun commented 11 years ago

Right. Many people wouldn't have composer as well. So in our README, we shall mention installing composer + installing the dependencies via composer.

Since the project is not mature yet, we can skip that for now.