masperro / httplib2

Automatically exported from code.google.com/p/httplib2
0 stars 0 forks source link

FileCache is not thread/multiprocess safe #125

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
As noted in the comment in the file, the FileCache may not behave well in the 
presence of many threads/processes all writing to the same cache.

The patch attached fixes this (at least for POSIX systems).

Original issue reported on code.google.com by toby.o.h...@gmail.com on 11 Jan 2011 at 4:06

Attachments:

GoogleCodeExporter commented 8 years ago
Looks good, have you tested this under windows?

Original comment by joe.gregorio@gmail.com on 11 Feb 2011 at 5:15

GoogleCodeExporter commented 8 years ago
Sorry, no - and I won't be likely to any time soon, I'm afraid. In principle it 
should work, it just won't be thread safe on Windows - but the existing cache 
isn't anyway, so it oughtn't to be any worse. Untested, though.

Toby

Original comment by toby.o.h...@gmail.com on 11 Feb 2011 at 3:24

GoogleCodeExporter commented 8 years ago

Original comment by joe.gregorio@gmail.com on 13 Jun 2011 at 5:22

GoogleCodeExporter commented 8 years ago
Did you mean to close this? I can't see any code to fix it in the repository.

Original comment by toby.o.h...@gmail.com on 13 Jun 2011 at 6:43