search

masroorhasan / Kubernetes.DotNet

Kubernetes C# client for .NET Framework
https://www.nuget.org/packages/Kubernetes.DotNet
MIT License
41 stars 8 forks source link

Support for .NET Standard #4

Open masroorhasan opened 6 years ago

masroorhasan commented 6 years ago

swagger-codegen for C# supports dotnet standard 1.3. Support the standard 1.3 platform on separate branch.

mmisztal1980 commented 6 years ago

just curious, how is this coming along?

masroorhasan commented 6 years ago

Ola @mmisztal1980, unfortunately I won't be able to get to it for some time - but please feel free to send a PR and I will definitely be happy to review it :).

davidorbelian commented 6 years ago

Hey @masroorhasan. I just tried to move your existing source code to a new Net Standard project and looks like RestSharp does not support 1.3, only 2.0.

Also I would like you to look at dependencies and say what you think about this:

All are OK with Net Standard 1.3 except the RestSharp.

P.S. I did not check how does this build work yet, but the build is successful for now.

felixfbecker commented 6 years ago

So would it be possible to get .netstandard 2.0 support as a first step?

masroorhasan commented 6 years ago

@davidorbelian Thank you! The reason I kept this to DotNet.Framework only was exactly because of RestSharp issues with Net Standard. Since the underlying http client is rest sharp (from swagger codegen), making RestSharp a hard dependency. If you've tested with Net Standard 2.0 and its working then feel free to put up the PR :). The only thing i'm worried about is that RestSharp will build/compile fine with Net Standard 2.0 but blowing up at runtime due to underlying incompatibility.

@felixfbecker Unfortunately I don't have time/resources to investigate deeper into Net Standard compatibility but if David's PR is good to go that can definitely be an option.

felixfbecker commented 6 years ago

@davidorbelian could you share your progress? I was not able to get it to work myself

jvdenning commented 6 years ago

@davidorbelian I would be keen to do this - would be great to have a head start - any update possible? at least any gotchas/guidance? Many thanks in advance.

felixfbecker commented 6 years ago

I've been having an amazing experience with https://github.com/tintoy/dotnet-kube-client instead, which supports .NET standard.

davidorbelian commented 6 years ago

@felixfbecker @jvdenning Unfortunately no. Sorry for late answer. Now I'm very busy with my basic work and there is no time to experiment. I hope you find what you're looking for. Good luck!