search

massalabs / massa-name-service

Massa naming service
4 stars 1 forks source link

Smart contract #1

Closed AurelienFT closed 6 months ago

AurelienFT commented 6 months ago

This PR contains the full code source for the DNS smart contract. This contract should match the NFT standard of Massa (inspired from ERC721), the RFC of the DNS SC here (with adjustments for NFT standards) and implement all features listed here

The two main files are

@damip Can you ensure the smart contract match all the needs please.

@gregLibert and @leoloco can you review the code please.

AurelienFT commented 6 months ago

The file structure is weird. Why is there a smart-contract folder that wraps everything ? I don't understand why you use let for variables that do not change. Isn't it more time and space complex than const ? Why don't you use expect + error message when deserializing user inputs ?

This repository will also contains the website that will made for this project under another subdirectories. For const and except, @gregLibert pointed it also and I have fixed it.