Closed aoudiamoncef closed 1 year ago
Looks good, but need:
- black, ruff, mypy checks (and modifications)
Yep, I'll do it
- Need kubernetes stubs (pypi.org/project/kubernetes-stubs) in requirements_dev.txt
WTF, typing is really optional in Python hihi
- Remove kubernetes deps in requirements_dev.txt (only dev dependencies like linters, formatters...)
Oups
- Need doc for ServicePortConfig in docstrings and maybe others class?
It's a Kubernetes concept, I could add a small explanation.
@sydhds It's in the boite 💯
@sydhds
I removed all the exception handling stuff and logging.
We have a constant launching and terminating time:
launch: 5 seconds terminating: 30 seconds
This why I didn't put any smart logic to check the status of the pods, or check the state of removing of the namespace. For example, we use Services to be able to connect via SSH, and this one don't have any status, It will return Active, even if the pods are dead.
We'll lose lot of time and efforts if we want to cover the edge cases.
I thought about typing but I didn't make It because: The target classes aren't types.
I'll see how to integrate It easily with the existing codebase