massalabs / massa

The Decentralized and Scaled Blockchain
https://massa.net
5.56k stars 712 forks source link

Review IPV6 compatibility #1111

Closed massa-bot closed 2 years ago

massa-bot commented 2 years ago

In GitLab by @damip

Some people are reporting that Massa nodes are not accessible from IPV6.

Find where the problem lies and correct it.

massa-bot commented 2 years ago

In GitLab by @mercury.planetes

Could the problem be related to the way routability are checked by MassaBot?

massa-bot commented 2 years ago

In GitLab by @damip

@mercury.planetes The nodes themselves seem to not be accessible from IPV6 at all. Probably a problem with the bind strings, because within the program, everything is IPV4/IPV6 agnostic

massa-bot commented 2 years ago

In GitLab by @damip

created merge request !201 to address this issue

massa-bot commented 2 years ago

In GitLab by @damip

mentioned in merge request !201

massa-bot commented 2 years ago

In GitLab by @damip

@sebf can you take a look at the massabot on IPV6 cases ?

massa-bot commented 2 years ago

In GitLab by @sebf

I would need a routable IPV6/nodepubkey to test

massa-bot commented 2 years ago

In GitLab by @damip

test done and bugs repaired: node + massabot now work with IPV6.

Still need to make sure the node bind on [::] functions on Mac and Windows as well.

massa-bot commented 2 years ago

In GitLab by @yvan-sraka

changed title from Rev{-e-}iw IPV6 compatibility to Revi{+e+}w IPV6 compatibility

massa-bot commented 2 years ago

In GitLab by @mercury.planetes

Hey! I can check on mac - have one here. Hm... I also have windows hosts all over the world, so can try there too

massa-bot commented 2 years ago

In GitLab by @mercury.planetes

As I can see, wee need only test one can run massa-node on Mac and Windows with bind = [::]:31244 (and 31245)

1) tested on MacBook Air M1 - it works as expected 2) tested on Windows - no problems with configuration option bind = [::]:31244 (and 31245), works as expected

massa-bot commented 2 years ago

In GitLab by @damip

mentioned in commit 146c5367e074c7af285e538d6ee569ec47eec269