search

massalabs / station-massa-node-manager

MIT License
0 stars 0 forks source link

Refactor on Node Manager Plugin to have a proper code and install Eslint #32

Open 0xMazout opened 1 year ago

0xMazout commented 1 year ago

Context The Node Manager need a little refactor if we install EsLint , lots of types are Any.

It doesn't bring direct value and was out of the scope of the frontend issue. https://github.com/massalabs/thyra-node-manager-plugin/issues/25

So if we want to take some times on it we can install Eslint and Eslint config from massa. And clean the code to have a perfect code

How to Change all the Any types to real types Install Eslint and Correct all the errors related to this installation

Technical details Give the technical insights so anyone in the team can tackle the tasks - Dev

QA testing It's cannot be QA tested for the types and Eslint part by a PM , ask for a dev to do the verif in the CR

SlnPons commented 1 year ago

@0xMazout is it front-end or back-end related? It's important to try to follow (and feel free to even improve if needed ;) ) the issue's templates to put more context to explain what this is about. Otherwise I'll be forced to ping you again and again to understand it and prioritise it 😭

0xMazout commented 1 year ago

This repo plugin is only related to frontend.

Yes mybad this issue was created before i used the template.

Done ⛑

SlnPons commented 1 year ago

aah ok. It is now a good practice among the dev team to have 2 repos by projects: front-end vs. back-end?

0xMazout commented 1 year ago

I was totaly wrong , mismatch ideas , the backend is include in this project he was just hide , but my remarks are only related to typescript and frontend . You can't setup bad types in Golang

Mybad

So yes my remarks only concern the frontend which is based on Thomas Poc