Closed thomas-senechal closed 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a10d232
) 25.27% compared to head (695c558
) 27.96%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- The HTTP link for the Terms of Service isn't yet operational.
Will work once merged
- I haven't verified if installing a new version of MS requires re-acceptance of the ToS.
When the user accepts it the first time, we create an empty file, so next times the installer is ran (for example, for an update), we check if this file exists or not: https://github.com/massalabs/station/pull/1244/files#diff-4bc1993c44b0052596d7cbce5d4d3082232197d6c3fa2437af8385ca92d5d860R39-R45
If it already exists, that means user already agreed so we don't need to ask again
- The HTTP link for the Terms of Service isn't yet operational.
Will work once merged
- I haven't verified if installing a new version of MS requires re-acceptance of the ToS.
When the user accepts it the first time, we create an empty file, so next times the installer is ran (for example, for an update), we check if this file exists or not: https://github.com/massalabs/station/pull/1244/files#diff-4bc1993c44b0052596d7cbce5d4d3082232197d6c3fa2437af8385ca92d5d860R39-R45
If it already exists, that means user already agreed so we don't need to ask again
I know, but I haven't tested it :-)
Delivery Quality Checklist
[ ] Breaking Changes in API: Does this PR introduce breaking changes in the API?
[ ] Changelog:
[ ] Version Update Handling: Have you ensured that the version update by user is handled correctly?
[ ] PR Dependency: Does this PR depend on another PR?
[ ] Documentation: