massalabs / station

A gateway to the Massa blockchain
https://station.massa.net
27 stars 107 forks source link

Add tos to linux installer #1244

Closed thomas-senechal closed 1 year ago

thomas-senechal commented 1 year ago

Delivery Quality Checklist

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a10d232) 25.27% compared to head (695c558) 27.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1244 +/- ## ========================================== + Coverage 25.27% 27.96% +2.68% ========================================== Files 25 21 -4 Lines 1559 1402 -157 ========================================== - Hits 394 392 -2 + Misses 1152 997 -155 Partials 13 13 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/massalabs/station/pull/1244/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=massalabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thomas-senechal commented 1 year ago
  • The HTTP link for the Terms of Service isn't yet operational.

Will work once merged

  • I haven't verified if installing a new version of MS requires re-acceptance of the ToS.

When the user accepts it the first time, we create an empty file, so next times the installer is ran (for example, for an update), we check if this file exists or not: https://github.com/massalabs/station/pull/1244/files#diff-4bc1993c44b0052596d7cbce5d4d3082232197d6c3fa2437af8385ca92d5d860R39-R45

If it already exists, that means user already agreed so we don't need to ask again

gregLibert commented 1 year ago
  • The HTTP link for the Terms of Service isn't yet operational.

Will work once merged

  • I haven't verified if installing a new version of MS requires re-acceptance of the ToS.

When the user accepts it the first time, we create an empty file, so next times the installer is ran (for example, for an update), we check if this file exists or not: https://github.com/massalabs/station/pull/1244/files#diff-4bc1993c44b0052596d7cbce5d4d3082232197d6c3fa2437af8385ca92d5d860R39-R45

If it already exists, that means user already agreed so we don't need to ask again

I know, but I haven't tested it :-)