Closed Thykof closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
8ed54ff
) 25.46% compared to head (cbbafa3
) 25.46%.:exclamation: Current head cbbafa3 differs from pull request most recent head d0dca83. Consider uploading reports for the commit d0dca83 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Did you tried to run the
create_pkg.sh
script from your computer without the Dev IDs ? What happens in that case ?If packaging fails or if the installer does not work, I think we need to add an handling of building with and without the Dev IDs. Otherwise, we won't be able to build from our computers and will require to push, wait for 15min, to then check if it's working. And it's not a viable way of working IMO
I modifier the script, you can now run ./macos/create_pkg.sh amd64 "Developer ID Application: Massa Labs (9X8NWA3JHQ)" "Developer ID Installer: Massa Labs (9X8NWA3JHQ)"
or ./macos/create_pkg.sh amd64
QA on amr64 and amd64 OK
Delivery Quality Checklist
[ ] Breaking Changes in API: Does this PR introduce breaking changes in the API?
[ ] Changelog:
[ ] Version Update Handling: Have you ensured that the version update by user is handled correctly?
[ ] PR Dependency: Does this PR depend on another PR?
[ ] Documentation: