massalabs / station

A gateway to the Massa blockchain
https://station.massa.net
27 stars 107 forks source link

Sign and notarize macos app and installer #1281

Closed Thykof closed 9 months ago

Thykof commented 9 months ago

Delivery Quality Checklist

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8ed54ff) 25.46% compared to head (cbbafa3) 25.46%.

:exclamation: Current head cbbafa3 differs from pull request most recent head d0dca83. Consider uploading reports for the commit d0dca83 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1281 +/- ## ======================================= Coverage 25.46% 25.46% ======================================= Files 25 25 Lines 1547 1547 ======================================= Hits 394 394 Misses 1140 1140 Partials 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thykof commented 9 months ago

Did you tried to run the create_pkg.sh script from your computer without the Dev IDs ? What happens in that case ?

If packaging fails or if the installer does not work, I think we need to add an handling of building with and without the Dev IDs. Otherwise, we won't be able to build from our computers and will require to push, wait for 15min, to then check if it's working. And it's not a viable way of working IMO

I modifier the script, you can now run ./macos/create_pkg.sh amd64 "Developer ID Application: Massa Labs (9X8NWA3JHQ)" "Developer ID Installer: Massa Labs (9X8NWA3JHQ)" or ./macos/create_pkg.sh amd64

Thykof commented 9 months ago

QA on amr64 and amd64 OK