massalabs / station

A gateway to the Massa blockchain
https://station.massa.net
27 stars 107 forks source link

1286 replace dns with hosts file macos #1292

Closed thomas-senechal closed 10 months ago

thomas-senechal commented 11 months ago

Delivery Quality Checklist

QA Review

  1. Uninstall MS
  2. Download the installer from https://github.com/massalabs/station/actions/runs/7143188946
  3. Install MS
  4. Run MS, it should work fine (except WoC since *.massa is disable)
  5. Open a terminal and copy paste:
    grep "station.massa" /etc/hosts
  6. You should see a line with 127.0.0.1 station.massa
  7. Uninstall MS again
  8. Open a terminal and copy paste:
    grep "station.massa" /etc/hosts
  9. You should see no new line
codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d9e2f96) 25.46% compared to head (741017e) 25.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1292 +/- ## ======================================= Coverage 25.46% 25.46% ======================================= Files 25 25 Lines 1547 1547 ======================================= Hits 394 394 Misses 1140 1140 Partials 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thomas-senechal commented 10 months ago

Tested by Nathan, Solène and myself on ARM64 and AMD64