massalabs / station

A gateway to the Massa blockchain
https://station.massa.net
27 stars 107 forks source link

1286 remove acrylic dns from windows installer #1293

Closed thomas-senechal closed 10 months ago

thomas-senechal commented 10 months ago

Delivery Quality Checklist

QA Review

  1. Uninstall MS
  2. Download the installer from https://github.com/massalabs/station/actions/runs/7169232980?pr=1293
  3. Install MS
  4. Run MS, it should work fine (except WoC since *.massa is disable)
  5. Open file explorer and copy paste the following path:
    %windir%\System32\drivers\etc\
  6. Open the hosts file
  7. You should see a line with 127.0.0.1 station.massa
  8. You can close the file, but not the file explorer
  9. Uninstall MS again
  10. Reopen the hosts file
  11. You should see no line mentionning station.massa
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c68a324) 25.46% compared to head (c5cf790) 25.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1293 +/- ## ======================================= Coverage 25.46% 25.46% ======================================= Files 25 25 Lines 1547 1547 ======================================= Hits 394 394 Misses 1140 1140 Partials 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thomas-senechal commented 10 months ago

A side note:

We might consider renaming our installer files, using 'installer' as a prefix. This would ensure they appear first in the list of artifacts and enhance readability.

What do you think? Of course, this change should be addressed in a separate issue and would require synchronization with the website, among other things.

If you are talking about the release artifacts, I'm not sure it's really important since most people are using the website to download the installers.

But this change shouldn't take much time and should be better for users downloading throught GitHub releases