Closed SlnPons closed 1 year ago
My suggestion is to construct the following API on Thyra side:
/plugin/manager
/plugin/manager/register
/plugin/manager/{name}
/plugin/manager/{name}/restart
/plugin/manager/{name}/stop
/plugin/manager/{name}/start
To work end-to-end implies to add some new functionalities on the plugin side:
What i would need from my side atm is when i call get plugin/manager to have per plugin :
Name : string : name of the plugin Description : string : describe the plugin with a sentence to display it has a tooltip Status : bool : is it ready to launch or not Logo : string :Url to load the image of the plugin
See here exhaustive list of what the plugins will have to share with Thyra: https://github.com/massalabs/thyra/issues/384
Hey @gregLibert
what's the difference between:
GET /mgnt/plugins
=> retrieve the list of plugins
and GET /plugin-manager
=> retrieve the list of plugins
I don't see the following endpoints created? /plugin/manager/{name}/restart POST: Restart a remote plugin /plugin/manager/{name}/stop POST: Stop a remote plugin /plugin/manager/{name}/start POST: Start a remote plugin
Why? Should we address them separetly? If we talked about it, sorry :/, I don't remember the rational behind not doing it now.
- what's the difference between:
GET /mgnt/plugins
=> retrieve the list of plugins andGET /plugin-manager
=> retrieve the list of plugins
/plugin-manager
is the new plugin manager. I guess that /mgnt/plugins
is the old version
2. I don't see the following endpoints created? /plugin/manager/{name}/restart POST: Restart a remote plugin /plugin/manager/{name}/stop POST: Stop a remote plugin /plugin/manager/{name}/start POST: Start a remote plugin
Why? Should we address them separetly? If we talked about it, sorry :/, I don't remember the rational behind not doing it now.
Yeah, no time to takle that. Sorry. To be done in another issue.
Context Today, our plug-in manager has very limited functionalities. It can run a manually installed plug-in on a certain port and read some info. The objective of this ticket is to extend its capabilities by allowing it to install, detect the status and uninstall plugins automatically.
User flow
Delete a plug-in that is already installed a. user clicks on the "delete" button b. user sees a pop-up from Thyra saying: are you sure you want to delete it? Yes / NO c. user clicks on "yes", plugin is removed from the page AND from his computer.
Install a plug-in that exist a. user clicks on install b. user sees the plugin listed on the page c. user can clicks on "access" button and a new page to the plugin opened d. user can use the plugin
see if a plug-in is Active: installed + in-use Inactive: installed + not in-use NB: not certain of the definition here but the idea behind active / inactive is for the user to be able to have some plugins installed but to not use them. For instance, they want to try 2 diff. wallet plugin they installed them both and decide to only use one after the other. - can be discussed!
How to
Technical details Give the technical insights so anyone in the team can tackle the tasks - Dev
QA testing Does this task require some QA tests ? If yes, explain how to validate it