massalabs / station

A gateway to the Massa blockchain
https://station.massa.net
27 stars 107 forks source link

Installation - Improve how CA are handled on windows #955

Open gregLibert opened 1 year ago

gregLibert commented 1 year ago

Instead of doing everything by hand (https://github.com/massalabs/station/pull/954), we should use google syscall functions for windows such as:

open question: Can procCertAddEncodedCertificateToStore be replaced by procCertAddCertificateContextToStore ?

gregLibert commented 1 year ago

code sample https://github.com/cloudfoundry/systemcerts/blob/main/root_windows.go#L35

Thykof commented 1 year ago

This has been implemented in https://github.com/massalabs/station/blob/e14cf8d303462b9b80fa7f5f473962a7b970ac6b/pkg/certstore/store_windows.go#L68

However we do not use this package certstore.

Currently the code use this package: https://github.com/massalabs/station/blob/37035861e5a3b1db7a0e2eb8cff8b7923206b673/pkg/certificate/store/store_windows.go#L22

We have to refactor and use package certstore instead.

SlnPons commented 9 months ago

@Thykof do you think we should address this issue soon?

Thykof commented 9 months ago

@Thykof do you think we should address this issue soon?

I guess next time we work on CA, we can tackle this refacto.