massbays-tech / MassWateR

R package for working with Massachusetts surface water quality data
https://massbays-tech.github.io/MassWateR
Creative Commons Zero v1.0 Universal
11 stars 3 forks source link

Create time series seasonal function #23

Closed fawda123 closed 2 years ago

fawda123 commented 2 years ago

Can be similar to outlier check function in plot format, but no outlier labels and include different plot format types (e.g., boxplot, bars). Need to include:

ben-wetherill commented 2 years ago

Looks very good. Here are my comments:

  1. If running for type="bar" or "jitterbar", can we change the title to Average ____?
  2. I'm not crazy about the line used for the lower threshold. I think it should be thinner and more of a line than separate dots.
  3. If filtering by site or date, can we add that to the title?
fawda123 commented 2 years ago

Should all be addressed now, I created a title formatting function that's recycled for the other analysis plot functions. I figured this was appropriate. I also redid the line formats for the thresholds, we can discuss further if needed.

ben-wetherill commented 2 years ago

Average looks good in the title now. Date filtering is mentioned, but site filtering does not show up in the title. Is it possible to put the actual date range in the title?
The site filter could get long, so maybe we don't want to put that detail in the title. The threshold line formats look better.

fawda123 commented 2 years ago

@ben-wetherill I modified the function for the plot titles to include site (only mentions results are filtered by sites and does not include actual site names) and the date range. The title could get long in some cases, so I also added an optional argument to all of the analysis functions to scale the title size (ttlsize argument).

ben-wetherill commented 2 years ago

Looks good!