Closed fawda123 closed 1 year ago
Started here 31763927cffa710fb75f57c7c6bd85d57285ee8a
Should be mostly done, but need to figure out how to correctly assign the Result Sample Fraction
column to the results file because it creates a one to many join, i.e., there is no way to figure out how the WQX Parameter
column in wqxdat
maps to the results file.
The WQX Output is looking very nice and I think this will be a value add for groups that are struggling with WQX. Here are items I noticed:
@ben-wetherill I think I've got these items taken care of now. Give it a go on your side when able. Thanks!
From the issue list above...
New items (Sorry, I think I have been confusing myself with these activity types):
One more new logic item: For Sample Collection Method Context, add the logic "If Sample Collection Method ID was populated with the default of "Grab", use the default Method Context of "MassWateR"."
Sorry. One more new logic item: Updated Activity ID formula to include abbreviations for Field Blanks and Lab Blanks.
@ben-wetherill no problem, the updates should now be included in tabMWRwqx
.
For the Sample Collection Method ID, Method Context, and Equipment Name columns, the activity types for 'Sample-Routine', 'Quality Control Sample-Field Blank', 'Quality Control Sample-Field Replicate' are now included. I wasn't sure if 'Quality Control Field Replicate Msr/Obs' should also be included, so I left it out.
Status of new items:
Output for WQX will be an excel file with three tabs, use the writexl package on ROpenSci to do this, also include libxlsxwriter for Ubuntu build. The template WQX file includes a fourth logic tab that is not included in the output.