search

massbays-tech / MassWateR

R package for working with Massachusetts surface water quality data
https://massbays-tech.github.io/MassWateR
Creative Commons Zero v1.0 Universal
11 stars 3 forks source link

Miscellaneous qcMWRreview() #45

Closed ben-wetherill closed 1 year ago

ben-wetherill commented 1 year ago

A few miscellaneous items for qcMWRreview()

  1. If there are no UQLs in the DQO accuracy file (ie. NA in every cell), the UQL column in the DQO accuracy output is blank. It would be more consistent if it had "-" marks in each cell.
  2. In all of the output tables, the parameters are listed in alphabetical order. However, in the DQO accuracy tables, the parameters are listed in the same order they were in the input files. Could the DQO accuracy and frequency tables also be sorted in alphabetical order so everything is aligned?
  3. I think we have defined decimal limits for many of the units of measure in the output tables. In the raw data lab/spike and instrument check tables, can we limit decimals for % and % recovery values to 1 decimal in the spike and result columns?

Here are supporting files. OARSTest_FreComDQO.xlsx OARSTest_AccuracyDQO_withDO.xlsx OARSTest_Results_2022_noair.xlsx

fawda123 commented 1 year ago

@ben-wetherill these should all be fixed now. For the third item, I set rounding at 3 decimal places for all parameters, except sp. conductivity set as 1. I had this somewhere else in the code, so I just replicated it for consistency. Let me know if you want it changed to 1 for all.

ben-wetherill commented 1 year ago

Tested items above:

  1. is good
  2. is good
  3. is good