massdosage / citrine-scheduler

Java web application which can be used to configure, manage and monitor the running of various tasks
Apache License 2.0
4 stars 4 forks source link

Change the dependency of citrine.properties to be in Tomcat classpath #38

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
A change to add citrine.properties to be added some where inside the war would 
be great.

Original issue reported on code.google.com by Jeygo...@gmail.com on 7 Jun 2011 at 7:53

GoogleCodeExporter commented 9 years ago
How would this work? The war file is distributed publically and putting the 
configuration in there would mean you would need to unpack the war, modify the 
config, pack it up again and then deploy it? It seems like a lot of work and 
having the properties file on the classpath means you can deploy new war files 
without needing to go through any extra steps.

What is the problem with having it outside of the war? It's an extra initial 
setup step but after that I think the benefits of having the config separate 
are worth it.

Original comment by massdosage on 7 Jun 2011 at 8:54

GoogleCodeExporter commented 9 years ago
It is actually not the convenience that is the question. Usually, in any 
application that is being used or developed the standards to have the config 
files in application specific folders....Here the configs are application 
specific and adding it to classpath would be kind of not a fair approved 
process..In case, If I would like to use the citrine as a exploded war where do 
I have to add the config file? 

Original comment by Jeygo...@gmail.com on 7 Jun 2011 at 9:03

GoogleCodeExporter commented 9 years ago
citine.properties needs to be on Tomcat's classpath. What folders go on 
Tomcat's classpath vary depending on the version of Tomcat. For Tomcat 6.0.30 
we put citrine.properties in TOMCAT_HOME/lib/. If I understand correctly this 
is what you want right? So this isn't actually an issue?

Original comment by massdosage on 7 Jun 2011 at 9:20

GoogleCodeExporter commented 9 years ago
This is not an issue, this would be more like an enhancement that would make it 
better.It would be good, to have citrine.properties(application specific 
configurable properties) contained inside an web app rather than outside it or 
in classpath.

Original comment by Jeygo...@gmail.com on 7 Jun 2011 at 9:24

GoogleCodeExporter commented 9 years ago
I still don't see how I could do this without preventing the use case where 
it's outside the web app. If I put citrine.properties inside the war file which 
gets distributed then everyone will be forced to have it inside the war (or 
manually remove it). If you want this feature why not write a script which 
downloads the war file from here, unpacks it, puts citrine.properties inside 
WEB-INF/classes, repacks the war file and then deploys it. This way you get the 
functionality you are looking for and the war file can still be distributed as 
it currently is. Would that work?

Original comment by massdosage on 7 Jun 2011 at 9:55

GoogleCodeExporter commented 9 years ago

Original comment by massdosage on 13 Jul 2012 at 1:53