search

massdriver-cloud / massdriver-cli

Deprecated. See https://github.com/massdriver-cloud/mass
https://massdriver.cloud
Apache License 2.0
3 stars 2 forks source link

Update README.md #105

Closed WillBeebe closed 2 years ago

coryodaniel commented 2 years ago

@chrisghill is importing the new template into the CLI so customers get it to. It'll include PARAMS:START fences as well so that @jaketf's python script can keep users params, connections, and artifact docs up to date in the readme.

New template is pretty tight -> https://github.com/massdriver-cloud/aws-vpc

jaketf commented 2 years ago

@coryodaniel I'm a bit confused. On Friday I thought this was supposed to be the "go forward" bundle repo template. that aws-vpc readme does look dope is there a PR for that template @chrisghill is using somewhere? I can work on getting the python script into our workflow but I wanna make sure I'm starting in the right place :)

coryodaniel commented 2 years ago

He’s been working on putting the new template together. We rolled it to all the pre-existing bundles. They have the PARAMS:START tokens in them. He’s replacing the README here w the same template.

We’ll put the Python script in precommit (existing repos and the template dir in the cli) so it keeps those PARAMS and CONNECTIONS sections updated.

we can add the PARAMS tokens to this in the meantime. The contents of the README should t matter besides those tokens.

WillBeebe commented 2 years ago

Yeah this PR is no good anymore. I opened it as tracking for the readme edits. I thought this would be reviewed, approved, merged, then we'd copy over to the bundle repos.

Every bundle PR I opened for public launch has Readme edits so I'll toss those and just keep the massdriver yaml edits