search

massdriver-cloud / terraform-provider-massdriver

https://massdriver.cloud
Apache License 2.0
0 stars 0 forks source link

Put localstack on port 4568 instead of 4566 #26

Closed akasprzok closed 12 months ago

akasprzok commented 12 months ago

This way it won't conflict with the Massdriver devContainer, which would otherwise have to be destroyed before this one can be spun up.

chrisghill commented 12 months ago

We may want to consider making this change in the massdriver repo instead of here in the open source provider. If we're moving services off of their standard port and onto custom ports, its probably best to isolate that to private/internal projects instead of making open source projects non-standard.

Curious to hear your thoughts @xpositivityx - I won't block this if it's urgent.

akasprzok commented 12 months ago

We may want to consider making this change in the massdriver repo instead of here in the open source provider. If we're moving services off of their standard port and onto custom ports, its probably best to isolate that to private/internal projects instead of making open source projects non-standard.

Curious to hear your thoughts @xpositivityx - I won't block this if it's urgent.

That's a good point. Closing.