massej / RadioHLSConverter.backend.serverless

RadioHLSConverter.backend.serverless
GNU General Public License v3.0
7 stars 2 forks source link

Memory usage rises rapidly-Possible memory leak in window 7 #4

Closed stavros92 closed 1 year ago

stavros92 commented 1 year ago

It seems there is a memory leak in windows 7 . Memory usage rises progressively extremely high - very fast . In windows 10 there is no such problem.

jonathanmassehsj commented 1 year ago

Hi @stavros92,

Many thanks for your reporting.

It’s probably a memory leak from the NET Core from Windows 7, make sure you have the latest long-term NET Core version 6.

Which version of NET Core did you use on Windows 7?

stavros92 commented 1 year ago

Hi! I am using dotnet v6.0.404 in windows 7 64bit. Memory usage gets crazy (> 1GB after just an hour of usage and growing continuously....)

jonathanmassehsj commented 1 year ago

I did a fresh install of Windows 7 SP1 Pro x64 and installed dotnet v6.0.404.

I was not able to replicate the issue, it stayed at around 132 mb of memory for more than 4 hours.

image

Did you have your appsettings.json configuration file by any chance? Maybe it's settings issue

massej commented 1 year ago

I just released version 1.0.13 which should help the memory issue you had, let me know if version 1.0.13 fix the issue

stavros92 commented 1 year ago

Hello! Unfortunately the memory leak has not been resolved in the new version...(See update below screenshot-cause found). I am attaching a screenshot after just 30 minutes where memory has climbed up to 1GB. In two other computers running windows 10 64bit the memory usage is stable and around just 35kb. I am also attaching my appsettings.json file (I have just altered the first station entry section url leaving the rest of the included demo file intact) snap appsettings.json.txt

UPDATE!!!!! UPDATE!!!!! It seems I have finaly isolated the issue! Tried the latest winamp version (5.9xx) and the problem went away. I was using an old winamp version (5.52) . I do not know what could be the difference and what the player has to do with it, but apparently...it does!

stavros92 commented 1 year ago

UPDATE 2. Unfortunetely although better, it seems that the memory leak still exists.... I left winamp running sure that everything is ok now, but I checked today (appr. 3days continyously playing) and the memory usage of radiohlsconverter was at 44 GB! (YEP 44 GB)!!!

jonathanmassehsj commented 1 year ago

44GB thats alot, mine stay at around 100 mb even after 24 hours of playing in Winamp.

Can you send me your configuration file, I will try to run it in my Windows 7 environment.

EDIT : I just saw your last post before with appsettings, I will try it and give you my result.

stavros92 commented 1 year ago

I am attaching it again. I have also seen this maximum 44GB of memory usage when I was using the previous winamp version (whereas memory was climbing much faster). It seems that in my system where 64GB of ram is installed, windows prevents memory usage more than 44gb to the radiohlsconverter....

appsettings.json.txt

massej commented 1 year ago

Hi @stavros92,

I have a good news, I just replicated the issue with your config file and winamp 5.52.

Instead of creating a new buffer each time, I reuse the same buffer and it seems to fix the issue.

I just ran it for more than 1 hour and it's at around 30 mb.

You can try version 1.14 and let me know your result

stavros92 commented 1 year ago

Hello! Sorry I was out of town and forgot to confirm that issue is resolved and everything is working fine now! Thanks!

On Fri, 13 Jan 2023 at 03:59, massej @.***> wrote:

Closed #4 https://github.com/massej/RadioHLSConverter.backend.serverless/issues/4 as completed.

— Reply to this email directly, view it on GitHub https://github.com/massej/RadioHLSConverter.backend.serverless/issues/4#event-8216703043, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5BBYBBHT25IDHMB5OG6BX3WSCZJBANCNFSM6AAAAAATOLK3NM . You are receiving this because you were mentioned.Message ID: <massej/RadioHLSConverter.backend. @.***>