search

massemanet / eper

Erlang performance and debugging tools
MIT License
437 stars 128 forks source link

Erlang 21 compat #57

Closed GalaxyGorilla closed 6 years ago

GalaxyGorilla commented 6 years ago

When I try to compile eper with erlang 21 I just get

 % ./rebar3 compile
===> Verifying dependencies...
===> Compiling eper
===> Compiling src/redbug.erl failed

which is not exactly a helpful error message :P.

I fiddled a little bit around, removed the stacktrace statements and some other stuff which might be incompatible with erlang 21. Also I removed the ?log macros which look like a dark art anyway, but all this did not change anything. Any idea what's going on here?

GalaxyGorilla commented 6 years ago

OK, this is because of warnings_as_errors in the rebar.config. Thanks to @michalwski who mentioned the issue in esl/MongooseIM#1947! Weirdly I don't even get any warning printed on my machine :(.

EDIT: I close this issue since IMHO this option makes sense to have plus it is overridable by the top level app. See https://www.rebar3.org/docs/configuration.

massemanet commented 6 years ago

trying to work around this with evil hacks in rebar.config.script

massemanet commented 6 years ago

vsn 0.99.1 of eper should be OTP21 clean