massenergize / frontend-admin

Frontend for the Admin Portal. This web interface is used by Community Admins (cadmins) to administer community-specific portals and by Super Admins to administer the entire MassEnergize web platform.
4 stars 3 forks source link

Two admin portal bug fixes - 1115 and 967 #1122

Closed BradHN1 closed 8 months ago

BradHN1 commented 9 months ago

Summary / Highlights

This PR should have been to Dev but I accidentally committed these fixes to the development branch.

1115 Unable to create team

967 A minor typo.

These fixes should get deployed to Dev (update version number to 4.13.6 and tag as dev@4.13.6) and then be merged into Canary and then to Prod when that is deployed.

Details (Give details about what this PR accomplishes, include any screenshots etc)

The creating team bug was an undefined variable (isSuperAdmin).

Testing Steps (Provide details on how your changes can be tested)

Create a team in the admin portal. Should not give a blank screen.

Requirements (place an x in each [ ])

Transparency (Project board)
BradHN1 commented 9 months ago

@frimpongopoku - sorry I thought I had tested it but didn’t remember. Could you fix it and also #1118 ?

On Jan 31, 2024, at 10:05 AM, Frimpong Opoku Agyemang @.***> wrote:

@frimpongopoku requested changes on this pull request.

In app/containers/MassEnergizeSuperAdmin/Teams/CreateNewTeamForm.js https://github.com/massenergize/frontend-admin/pull/1122#discussion_r1472955338:

@@ -43,11 +43,14 @@ const styles = (theme) => ({ }) { const [parents, setParents] = React.useState([]);

  • const isSuperAdmin = auth?.is_super_admin; @BradHN1 https://github.com/BradHN1 your code still breaks. You did not import "auth" as a prop before using it inside "CreateNewTeamForm".

— Reply to this email directly, view it on GitHub https://github.com/massenergize/frontend-admin/pull/1122#pullrequestreview-1853960698, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBVDZG5HNHQBHP4YRVP5UTYRJMU7AVCNFSM6AAAAABCPU5N2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJTHE3DANRZHA. You are receiving this because you were mentioned.

frimpongopoku commented 8 months ago

@abdullai-t fixed this in another PR 🙏🏾