Feat: #1119 Add Category and Subcategory filters to action creation & edit form - Githubissues

massenergize / frontend-admin

Frontend for the Admin Portal. This web interface is used by Community Admins (cadmins) to administer community-specific portals and by Super Admins to administer the entire MassEnergize web platform.

4 stars 3 forks source link

Feat: #1119 Add Category and Subcategory filters to action creation & edit form #1202

Closed frimpongopoku closed 3 months ago

frimpongopoku commented 3 months ago

Summary / Highlights

Works with API PR :https://github.com/massenergize/api/pull/1041

[X] You can now filter CCActions based on categories and Subcategories when creating new action or editing an action.

https://github.com/massenergize/frontend-admin/assets/26961591/61569846-f4cb-4f14-8ff7-f89a31c43950

Details (Give details about what this PR accomplishes, include any screenshots etc.)

Testing Steps (Provide details on how your changes can be tested)

Requirements

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've tested my changes manually.
[ ] I've added unit tests to my PR.

Transparency (Project board)

[ ] I've given my PR a meaningful title.
[ ] I linked this PR to the relevant issue.
[ ] I moved the linked issue from the "Sprint backlog" to "In progress" when I started this.
[ ] I moved the linked issue to "QA Verification" now that it is ready to merge.

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Performance improvement
[ ] Feature removal
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

[x] It's submitted to the dev branch or to a feature branch, not the main branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: Contributing Guidelines
[ ] New/updated tests are included

Other information: Any otherthing we need to know

BradHN1 commented 3 months ago

@frimpongopoku - from watching the video, a couple of comments:

as a pull-down menu, I would prefer if the selected item for Category, Subcategory or Action were not in the gray oval container, but just be shown as bold text.
when no Category is chosen (the --- option), the Subcategory selector should not be active, and no choice shown.

frimpongopoku commented 3 months ago

LGTM a couple cosmetic comments @BradHN1, it should look like this now.