search

massenergize / frontend-portal

Front End Code for the MassEnergize Community Portal. The community portal is customized for each participating community, and has the canonical URL https://community.massenergize.org/<community-name>/. For example, https://community.massenergize.org/wayland/.
MIT License
5 stars 3 forks source link

have indiv team open in a new tab #285

Closed kaatvds closed 4 years ago

kaatvds commented 4 years ago

When clicking on a team in the all teams page, let it open a new tab.

jkatofsky commented 4 years ago

This would be inconsistent with the single action and event pages; is there a particular reason why we want to open in a new tab? @kaatvds

Also, this would mean that we have to redo all of the up-front fetching for the newly-opened tab. Not a huge deal, but a bit inefficient if we can avoid it.

BradHN1 commented 4 years ago

I agree; for linking to locations which are within our site, I don’t think we should open a new tab.

++++++++++++++++++++ Bradley Hubbard-Nelson 221 Nashawtuc Rd Concord, MA 01742 bradhn@mindspring.com hubbardnelson.org http://hubbardnelson.org/ Tel: 978-505-7128 (cell)

On Jul 20, 2020, at 5:02 PM, Josh Katofsky notifications@github.com wrote:

This would be inconsistent with the single action and event pages; is there a particular reason why we want to open in a new tab? @kaatvds https://github.com/kaatvds Also, this would mean that we have to redo all of the up-front fetching for the newly-opened tab. Not a huge deal, but a bit inefficient if we can avoid it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/massenergize/frontend-portal/issues/285#issuecomment-661331571, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBVDZHKCZ2DAE3NVIKVCATR4SWHLANCNFSM4PCX4SSA.

jkatofsky commented 4 years ago

If people want to open something in a new tab, they can always right-click the team and select "open in a new tab", or hold Command (macOS) / Control (Windows) while clicking.

kaatvds commented 4 years ago

Yes, that's how I was doing it. i guess I was interacting with the pages much more (creating and deleting teams as an admin) than your average user would. Closed the ticket. Kaat

On Mon, Jul 20, 2020 at 5:50 PM Josh Katofsky notifications@github.com wrote:

If people want to open something in a new tab, they can always right-click the team and select "open in a new tab", or hold Command (macOS) / Control (Windows) while clicking.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/massenergize/frontend-portal/issues/285#issuecomment-661351903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHHAB3C5CNHQL7NXLNF32VDR4S32XANCNFSM4PCX4SSA .

-- -- Kaat Vander Straeten, Ph.D.

"Look, Ma, no hands!" "“Ring the bells that still can ring / Forget your perfect offering / There is a crack / A crack in everything / That’s how the light gets in” (Leonard Cohen)

Co-founder and Vice President of MassEnergize http://www.massenergize.org/, a 501(c)3 | Coordinator of Energize Wayland http://www.energizewayland.org/ | Associate Member of the Wayland Energy and Climate Committee https://www.wayland.ma.us/Pages/WaylandMA_BComm/Energy/index (an MCAN https://www.massclimateaction.org/Chapter) | Co-founder of Transition Wayland http://transitionwayland.org/ | Certified Permaculture Designer (Sowing Solutions https://sowingsolutions.org/upcoming-courses/) | Graduate of E. Ingham's Life in the Soil classes (Environment Celebration https://environmentcelebration.com/) | Beekeeper, consultant, and founder of BEElieve Beekeepers

http://transitionwayland.org/beelieve