massgov / mayflower

Mayflower Mono Repo (react and pattern lab and documentation)
https://mayflower.digital.mass.gov/
GNU General Public License v2.0
26 stars 21 forks source link

DP-32007 [a11y] Download link normal state indicator #1901

Closed ygannett closed 6 months ago

ygannett commented 8 months ago

Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions

Description

After:

Screenshot 2024-04-19 at 11 36 01 AM

Note: The Backstop reference screenshots haven't been updated yet.

Related Issue / Ticket

Steps to Test

1.

Screenshots

Use something like licecap to capture gifs to demonstrate behaviors.

Additional Notes:

Anything else to add?

Impacted Areas in Application

*

@TODO

*

Today I learned...

clairesunstudio commented 6 months ago

The above suggestions are all about cleaning up the code comments.

I reviewed the Mayflower backstop report, all looks good except for the file icons colors are lighter now. I think we should at least set that to $c-link or even $c-font-link. What do you think? Screen Shot 2024-05-14 at 10 46 36 AM Screen Shot 2024-05-14 at 10 46 39 AM

I also noticed a change in the footnote size. Can you please confirm that it's expected? Screen Shot 2024-05-14 at 12 04 49 PM Screen Shot 2024-05-14 at 12 04 53 PM

ygannett commented 6 months ago

The backstop failure is not related to this PR's change.