Added an Outlook Desktop adblocker option to the extras menu

massgravel / Microsoft-Activation-Scripts

Open-source Windows and Office activator featuring HWID, Ohook, KMS38, and Online KMS activation methods, along with advanced troubleshooting.

https://massgrave.dev

GNU General Public License v3.0

97.97k stars 9.56k forks source link

Added an Outlook Desktop adblocker option to the extras menu #313

Closed Pyenb closed 10 months ago

Pyenb commented 10 months ago

Hey there, I tought that an Outlook desktop adblocker (as they are still in your inbox, even when activated), would be a nice addition for this wonderful project. So I went ahead and quickly implemented my version Outlook-desktop-ad-blocker in the Extras menu.

It works by simply blocking the outlook ads domain from accessing the internet with the windows hosts file.

I tried following the styling, but let me know if there is anything that I should change.

WindowsAddict commented 10 months ago

Hi @Pyenb Thanks for the PR, but unfortunately I would have to decline this request because of the following reasons:

The main focus of this project is on Activation, and if we start doing things like removing ads then there would be a request for Windows ads as well followed by block telemetry and so on and that will bloat the script which I'm trying to avoid.
Majority of users don't use the outlook app, they use it in the browser, and most already have an adblocker there.
Antivirus's do not like a script modifying hosts file.

Pyenb commented 10 months ago

Hi, thanks for the feedback.

Yeah I didn't think of that, but understandable. Still, I love your projects <3