search

massif-press / compcon

Digital character creator and player sheets for the LANCER TTRPG
https://compcon.app
GNU General Public License v3.0
279 stars 98 forks source link

[BUG] Horus fancy text not working properly when using themes #2340

Open AsgerToft opened 10 months ago

AsgerToft commented 10 months ago

Describe the bug The fancy text for some of the Horus things (like the manticore and minotaur frame entries) isn't properly blacked out before hovering over while using MSMC Solarized or Horus Terminal theme.

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on Themes, select MSMC Solarized or Horus Terminal
  3. Scroll down to Manticore Onboard Core System
  4. See error

Expected behavior I expected the fancy text to be properly blacked out so it was unreadable as normal with the GMS Red theme, but instead it was grey text on a black background, making it very readable. It still behaved correctly while hovering over it though.

Screenshots GMS Red Theme image Horus Terminal Theme image MSMC Solarized Theme image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

msprijatelj commented 10 months ago

Honestly, I think this makes the text more accessible as a result? I know that more than one person has requested the flashing text be toned down, as well.

vialra commented 8 months ago

Mhhh i guess it loses the Horus-mystique if it is visible the whole time. Which makes sense for the Horus theme but not really for MSCM imho. Removing it also would remove the "redacted" feel from gms.

The underlying "issue" is that horus is styled similar/same for all themes. Maybe that should be conditioned on the colorscheme of the theme? compcon/src/ui/style /typography.css

sad that you have to give up accessibility but maybe there is a way to get everything.