massif-press / compcon

Digital character creator and player sheets for the LANCER TTRPG
https://compcon.app
GNU General Public License v3.0
271 stars 98 forks source link

[BUG] Mods Don’t Display Added Custom Tags with {VAL} #2407

Open Sxoa opened 3 months ago

Sxoa commented 3 months ago

When I have a weapon Mod with a {Val} inside added_tags for a weapon mod it kicks back the error:

ERROR: e.tag.GetName is not a function

It doesn't stop the mod from being equipped or break comp/con. It just kicks back the error and doesn't display the tag on the equipment. This only applies to new tags apparently. The limited tag inside added_tags seems to work fine.

To Reproduce Steps to reproduce the behavior: 1) Add the following to any LCP TAG: { "id": "tg_first_example_val_problem", "name": "First example of VAL problem {VAL}", "description": "Lorem ipsum" }

WEAPON MOD (change license to whatever). { "id": "wm_test_one", "name": "Val test one", "sp": 2, "allowed_types": [ "Nexus" ], "source": "IPS-N", "license": "THESEUS", "license_level": 2, "effect": "Lorem ipsum", "description": "Lorem ipsum", "added_tags": [ { "id": "tg_first_example_val_problem", "val": 1 }, { "id": "tg_ap" } ], "license_id": "mf_theseus" }

2) Create a character and equip the mods. 3) "ERROR: e.tag.GetName is not a function" appears.

Desktop (please complete the following information):

Also occurs in Chrome for iPad but I don't have the device to hand to get the specifics on it.