search

massif-press / compcon

Digital character creator and player sheets for the LANCER TTRPG
https://compcon.app
GNU General Public License v3.0
279 stars 98 forks source link

[BUG] Triggers from a LCP are displayed even when it's disabled #2468

Open Lorenzo-Sepe opened 4 months ago

Lorenzo-Sepe commented 4 months ago

Both in Compendium and Pilot Roster, I get shown Skill Triggers from one LCP even if it's disabled, however, they disappear when another LCP in disabled as well.

To Reproduce Steps to reproduce the behavior:

  1. Install both Legionaire and In Golden Flame LCPs (links at https://kastark.itch.io/legionnaire and https://vexwerewolf.itch.io/in-golden-flame-act-1)
  2. Once installed, disable the Golden Flame LCP from the Package Manager
  3. Go either to Compendium->Skill Triggers or edin skill trigger from a character already created
  4. The triggers from Golden Flames should still be accessible.
  5. Disable the Legionaire LCP from the Package Manager and reload the page,
  6. Go either to Compendium->Skill Triggers or edin skill trigger from a character already created
  7. The triggers are not available.

Expected behavior The triggers shouldn't be available if the Golden Flame LCP isn't active, and they shouldn't disappear when an unrelated LCP (Legionaire) is disabled in its stead.

Desktop (please complete the following information):

Since the problem was

msprijatelj commented 4 months ago

Similar to #2249, but it’s odd that disabling an unrelated lcp would cause this issue.

msprijatelj commented 4 months ago

Having trouble reproducing the "Disable Legionnaire -> IGF Skill triggers not available" bug. The other bug ("disabling IGF doesn't hide IGF skills") is reproducible and covered by #2249 . If someone else can verify the first bug I mentioned, we can keep this open.

@Lorenzo-Sepe If you have additional information (like is this only while using a Cloud Account, or if other LCPs were installed at the time as well as their "enabled/disabled" state), it could be helpful for reproducing the issue.

msprijatelj commented 4 months ago

Okay, so I see that while logged into a compcon account, if I refresh the skill trigger compendium page directly, it doesn't automatically load all the installed LCP skills. I think that's a loading issue rather than an LCP enabled/disabled issue though, as it occurs regardless of enabled/disabled LCPs.