massif-press / compcon

Digital character creator and player sheets for the LANCER TTRPG
https://compcon.app
GNU General Public License v3.0
271 stars 98 forks source link

[A11Y] Add accessible names to icons in nav menu #2473

Open nedredmond opened 3 weeks ago

nedredmond commented 3 weeks ago

Description

Adds names found in tooltip to aria-label on icon button to make them accessible to screen readers (previously read just "button").

For the compendium button, unwraps the anchor around it to prevent multiple nested focusable elements, which can confuse unsighted users.

For the vertical dots menu button, adds the attrs from the v-menu, which adds aria attributes like aria-expanded to help unsighted users understand that the button causes something to open and close.

Issue Number

N/A

Type of change

Bug fix (non-breaking change which fixes an issue)