massif-press / compcon

Digital character creator and player sheets for the LANCER TTRPG
https://compcon.app
GNU General Public License v3.0
271 stars 98 forks source link

[BUG] Free action skirmish locking out subsequent attacks #2481

Open Alfonts opened 3 weeks ago

Alfonts commented 3 weeks ago

Describe the bug If skirmish is taken as a free action, the 'Skirmish' button is greyed out. Additionally, the 'Attack' button in both Skirmish and Barrage is greyed out. These buttons then remain greyed out even for subsequent attacks. I.e., a player can't skirmish as a free action and then skirmish as a quick action (or skirmish as a free action and then barrage as a full action).

Note: the 'Barrage' button remains active; however, 'attack' button within the Barrage screen stays greyed out.

Weirdly, I've noticed that if I skirmish as a free action a second time, it unlocks the attack buttons again. They then stay unlocked no matter how many times I skirmish as a free action.

I have done this in Firefox (desktop), Firefox (Android) and Chrome (desktop).

To Reproduce Steps to reproduce the behavior:

  1. Go to Active Mode.
  2. Click on 'Skirmish'. You can do this either directly on a weapon or through the Quick Action menu—both create the fault.
  3. Click on 'Free Action'.
  4. Click 'Hit' or 'Miss'.
  5. Click 'Confirm'.
  6. The 'Skirmish' button next to weapons will be greyed out. The 'Skirmish' option from the Quick Action menu will be ticked. 'Barrage' is still available, but if you go into the menu, the 'Attack' button remains greyed out.
  7. Weird fix: If you repeat steps 2–5, 'Skirmish' becomes available again (both next to weapon and in Quick Action menu), and 'Attack' works for barrage.

Expected behavior If you Skirmish using the Free Action button, the 'Skirmish' option should still be available and you should be able to click 'Attack' within the Barrage menu.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.