massif-press / lancer-data

LANCER JSON Data
30 stars 29 forks source link

[BUG] Several deployables without limited tag use recall instead of deactivation #192

Open sealtrowitz opened 1 year ago

sealtrowitz commented 1 year ago

According to lancer-data documentation at https://github.com/massif-press/lancer-data#deployables : "A recall value will generate a recall action, removing the deployable from the user's Deployables list and refunding the system the cost value in charges. deactivation does the same as recall but does not refund the charge cost." Per discussion at https://github.com/massif-press/compcon/discussions/2298 , deployables without the limited tag should use deactivation, however several instead use recall. Full list that I was able to find is Hive Drone, Sentinel Drone, Tempest Drone, and Assassin Drone.

Hive Drone: https://github.com/massif-press/lancer-data/blob/fec54617dfcca5c4abc0c2eacd4592e80da75f5f/lib/systems.json#L1292

Sentinel Drone: https://github.com/massif-press/lancer-data/blob/fec54617dfcca5c4abc0c2eacd4592e80da75f5f/lib/systems.json#L1489

Tempest Drone: https://github.com/massif-press/lancer-data/blob/fec54617dfcca5c4abc0c2eacd4592e80da75f5f/lib/systems.json#L1607

Assassin Drone: https://github.com/massif-press/lancer-data/blob/fec54617dfcca5c4abc0c2eacd4592e80da75f5f/lib/systems.json#L1631

(sorry for the lazy formatting of this report, i've been pressed for time lately and wanted to finally post this since i haven't been able to yet!)

Eliemer commented 7 months ago

Hey i wanted to reopen this discussion cuz im finding that a lot of deployables dont have the Limited tag but also dont seem to follow this rule. I wanted some clarifications as to the intended behaviour here.

One example being the Jericho Cover. Its a deployable, can be recalled and redeployed, but has no Limited Tag. Especially confusing since it has two sections of cover that can be recalled individually