search

massimilianodelliubaldini / galaxy-integration-rpcs3

GOG Galaxy 2.0 Integration with RPCS3
MIT License
22 stars 6 forks source link

Proper referencing of API code #1

Open massimilianodelliubaldini opened 4 years ago

massimilianodelliubaldini commented 4 years ago

With regard to f644a958e3f8313b0c0d7ab00fe818d30d3efa19:

Prior work for Galaxy integrations has normally copied the code from src/galaxy into their respective repositories, but this is not a sustainable way of keeping up-to-date on the API.

The proper way to accomplish this would be to submodule the API, but in fact we only need the src/galaxy folder, and git does not support making a submodule of a subfolder of another repository.

This is an open question on how best to handle this. For now, I am following suit of previous authors by copying the src/galaxy folder.

massimilianodelliubaldini commented 4 years ago

I think I found what I'm looking for. I can use pip and PyPi to load the latest API without having to copy code myself. See here.

This does make installation more complicated for the user, since they'll need git, python, and pip to set up the plugin properly.