search

massimilianodelliubaldini / galaxy-integration-rpcs3

GOG Galaxy 2.0 Integration with RPCS3
MIT License
22 stars 6 forks source link

GameLibrarySettings feature #15

Open massimilianodelliubaldini opened 5 years ago

massimilianodelliubaldini commented 5 years ago

Just like game_times.json, this will include a standalone file that will hold a user's game tags and hidden flags. More work needs to be done, like updating on Tick, but for now this PR is just to get the process started.

To start, need to bump API to 0.51.

massimilianodelliubaldini commented 5 years ago

I probably need a way to specify to the user that they should write tags as individual JSON elements, not one big comma-delimited string. But JSON doesn't support comments, so how do I get that message across?

UncleGoogle commented 5 years ago

But JSON doesn't support comments, so how do I get that message across?

so why not yml or toml that is also more human-readable? :)

massimilianodelliubaldini commented 5 years ago

That is an option. I originally chose JSON because the game times functionality had already been developed in JSON. These library settings functions use almost the same logic.

I'm hesitant to switch because it means refactoring and writing new code, which could introduce more bugs. Then, either the user has to navigate 2 different file types to enter times and tags, or the game times code needs to be rewritten as well, which means they need to switch up what they do to enter game times.

massimilianodelliubaldini commented 5 years ago

I suppose the right answer to all this is to store all this information in 1 file, but for right now I'm waiting to see when the Galaxy client gets the update to take advantage of this feature.

UncleGoogle commented 5 years ago

I see. But can you explain this feature purpose in the plugin if the user has to prepare settings file manually? Maybe I do not understand this, but how it can be better than adding tags/hidden property manually with Galaxy UI?

massimilianodelliubaldini commented 5 years ago

You're asking about the feature's purpose as designed by Gog? I'm pretty sure it was to import categories from Steam as tags in Galaxy.

Why did I add it to the plugin? It could be useful if Galaxy loses track of tags, I think I saw an issue that someone created for it. Could also be useful if someone wanted to rename a tag wholesale. I agree though, if you have to add tags by hand, it's not much easier than doing it through Galaxy.

UncleGoogle commented 5 years ago

I see, thanks for explanation