search

massimilianodelliubaldini / galaxy-integration-rpcs3

GOG Galaxy 2.0 Integration with RPCS3
MIT License
22 stars 6 forks source link

Achievement/Trophy support #6

Closed massimilianodelliubaldini closed 5 years ago

massimilianodelliubaldini commented 5 years ago

RPCS3 supports trophies, and I want to add this functionality to the plugin.

massimilianodelliubaldini commented 5 years ago

1978b13e1aeb1abdde9d9f14786486fb2b38fb5a is a good start. The Trophy class itself works great standalone.

In the plugin however, when it comes across games that don't have trophies, the instance is created but not all of its attributes are set. Need to investigate that further.

massimilianodelliubaldini commented 5 years ago

88f2004651b5285b9f7b7d1ee418fe46a21842b5: imports are fixed now - no errors show up in the log. However, no trophies show up in Galaxy either.

I suspect the reason for this is because ColecoVision did not have achievements. :/

massimilianodelliubaldini commented 5 years ago

I can see unlocked achievements show up by name in the log files with no errors surrounding them, so I'm assuming the only reason left that they don't show up in Galaxy's GUI is how GOG deals with these games in their backend. I'll revisit this if/when PS3 becomes a supported platform.

2019-09-24 22:00:40.114 [Information][ (0)] [TID 16684][galaxy_client]: Successfully imported 0 achievements for game vision_BLUS30144
2019-09-24 22:00:40.114 [Information][ (0)] [TID 16684][galaxy_client]: Importing unlocked achievements for game vision_BLUS30144 succeeded.
2019-09-24 22:00:40.114 [Information][ (0)] [TID 16684][galaxy_client]: Successfully imported 1 achievements for game vision_BLUS30313
2019-09-24 22:00:40.115 [Information][ (0)] [TID 16684][galaxy_client]: Importing unlocked achievements for game vision_BLUS30313 succeeded.