massimilianodelliubaldini / galaxy-integration-rpcs3

GOG Galaxy 2.0 Integration with RPCS3
MIT License
22 stars 6 forks source link

Missing imported games #8

Closed massimilianodelliubaldini closed 4 years ago

massimilianodelliubaldini commented 4 years ago

Ratchet and Clank and Modern Warfare 2, were 2 games that the plugin discovered and imported, but then some weird things happened.

Galaxy problem or plugin problem, I do not know.

massimilianodelliubaldini commented 4 years ago

Found a clue form the GalaxyClient.log file:

2019-09-16 17:32:17.393 [Warning][ (0)] [TID 3080][galaxy_client]: GamesDbPiecesPullerByRelease retrieved response code 404, will treat game 'vision_BLUS30377' pieces as not set. 2019-09-16 17:32:17.393 [Information][ (0)] [TID 11996][galaxy_client]: Sending problem report of type GamesDb-Request-Error: {"Arguments":{"applicationType":"GOG Galaxy","clientVersion":"2.0.5.138","detectedOsVersion":"win10","os":"windows","osIdentification":"windows: Windows 10 10.0 (Build 18362)","productId":"vision_BLUS30377","returnCode":404,"updateChannel":""},"ProblemReport":"GamesDb-Request-Error"} 2019-09-16 17:32:17.393 [Warning][ (0)] [TID 3080][galaxy_client]: GamesDbPiecesPullerByRelease retrieved response code 404, will treat game 'vision_NPUA80643' pieces as not set. 2019-09-16 17:32:17.393 [Information][ (0)] [TID 3080][galaxy_client]: Discarding problem report because 0s elapsed since last sending of GamesDb-Request-Error problem.

These are the Game ID's for MW2 and R&C.

Another piece of information:

2019-09-15 14:15:24.921 [Information][ (0)] [TID 11124][galaxy_client]: Sending problem report of type GamesDb-Request-Error: {"Arguments":{"applicationType":"GOG Galaxy","clientVersion":"2.0.5.138","detectedOsVersion":"win10","os":"windows","osIdentification":"windows: Windows 10 10.0 (Build 18362)","productId":"vision_NPUA80643","returnCode":404,"updateChannel":""},"ProblemReport":"GamesDb-Request-Error"}

So it seems that, after messing with the release date (which for those 2 titles was "Invalid date ()") Galaxy's backend can no longer properly query for the games, and so they won't be showed in the front end.

I'll submit a bug report with GOG and see what they say.

TBemme commented 4 years ago

From my own tests and comments I've seen from GOG staff (so this only guesses/assumptions, not neccessarily what is happening) - this happens when a game fails to automatically find a "match" in the gamesdb. Because the id (and platform) can be anything, I think the match is performed based on the game_title that the plugin provides.

Games that don't automatically get matched have to wait for a staff member to do so manually. That can take a while, or other things can go wrong (if it is incorrectly marked as a DLC or spam, Galaxy will never show the game).

That second game id in the database appears to have been marked as spam: https://gamesdb.gog.com/platforms/vision/external_releases/NPUA80643

Plugins/users can't fix this unfortunately, only the staff can if you report it. That has happened to a couple of games I've tried to add with my plugins.

massimilianodelliubaldini commented 4 years ago

Thanks for the heads up! I'm surprised they have functionality to list games as spam.

I'll change the status of this issue and close it, since it seems to be unrelated to the plugin or API.