search

massimocandela / geofeed-finder

Utility to find geofeed files linked from rpsl.
BSD 3-Clause "New" or "Revised" License
74 stars 8 forks source link

Support GitHub CDN URL's #37

Open deluxor opened 3 months ago

deluxor commented 3 months ago

Hi @massimocandela,

Great work on this project!

I hope you don't mind this pull request. I have added support for parsing GitHub URLs in the blob format, which allows for direct downloading from the GitHub CDN. Additionally, I have moved all regex operations to the Util class for coherence.

This also closes https://github.com/massimocandela/geofeed-finder/issues/36

Screenshot 2024-06-03 221938

Best regards, João Duarte

andrewachen commented 2 months ago

Worth checking out this comment - https://github.com/massimocandela/geofeed-finder/pull/35#issuecomment-2045960844

deluxor commented 2 months ago

Worth checking out this comment - #35 (comment)

Hey @andrewachen, thank you for your insight. I should have checked the previous merge request before submitting mine. I fully agree with @massimocandela on stopping the misuse of RFC 9092 and eliminating nonsensical HTML pages.

Regarding my contribution here, It introduces support for reading CSV files from GitHub. Furthermore, it still uses current checks to ensure the content is not HTML; if it detects HTML content, it will be ignored accordingly. However, I leave the final decision to @massimocandela. If this approach doesn't align with the objectives, please feel free to reject the merge request.

Hope to help in other features / ways.