search

massive-oss / MassiveUnit

munit is a cross-platform unit testing framework for Haxe. Utilises metadata markup for test cases and includes tools for generating, compiling and running test cases from the command line.
Other
180 stars 56 forks source link

HTTPClient broken for Flash in 2.2.1 #151

Closed Gama11 closed 6 years ago

Gama11 commented 6 years ago

Flash support seems to be broken in 2.2.1. When creating a fresh project with haxelib run munit config (confirming everything with enter) and running haxe test.hxml, I get the following error:

C:\HaxeToolkit\haxe\lib\munit/2,2,1/massive/munit/client/HTTPClient.hx:256: characters 20-34 : Type not found : flash.LoadVars

@SlavaRa

jgranick commented 6 years ago

It was broken by this commit:

https://github.com/massiveinteractive/MassiveUnit/commit/adad6f212a5da3c1aa4603e2b8fcf40f4f9c927b#diff-f98ed25f69e97ef0d27c407840c7cae3

It removed flash9 code in favor of old flash8 code instead

SlavaRa commented 6 years ago

I'll fix it today

Aurel300 commented 6 years ago

Any status on this?

elsassph commented 6 years ago

Sorry, I forgot about it - here's a PR: https://github.com/massiveinteractive/MassiveUnit/pull/153

PS: what browser are you using to run the tests?

Aurel300 commented 6 years ago

If that was for me @elsassph, no browser – I just stumbled upon this when working on Flixel's unit tests.

elsassph commented 6 years ago

Ah yes that's another problem then: you should specify the targets you want to test so you don't compile for Flash.