fixed absolute path names

massive-oss / mcover

A cross platform code coverage framework for Haxe with testing and profiling applications. Supports AVM1, AVM2, JavaScript, C++, PHP and Neko.

Other

59 stars 9 forks source link

fixed absolute path names #49

Closed AlexHaxe closed 5 years ago

AlexHaxe commented 5 years ago

I've been playing around with VSCode extensions coverage-gutters and code-coverage to visualise coverage data in VSCode. coverage-gutters seems to be ok with current version of LcovPrintClient, but code-coverage can't work with paths generated from old version. New version uses or tries to use absolute paths and with those both extensions work expected.

Also added nodejs to supported targets.

elsassph commented 5 years ago

@AlexHaxe sorry, missed this PR - can you update it?

AlexHaxe commented 5 years ago

Thanks for merging my other pull requests.

I've rebased my branch, to make it compatible with current master.

elsassph commented 5 years ago

@AlexHaxe the fix I think is done at the wrong place - you're trying to figure information which is available during processing.

CoverageExpressionParser.hx has absolute paths for everything (but removes the classpath part) when creating the block references,
Coverage.hx builds the nodes using the block references.

AlexHaxe commented 5 years ago

Thanks for your feedback. Yeah, my solution isn't really optimal, I am working on a better one using locations collected in CoverageExpressionParser.

AlexHaxe commented 5 years ago

ok, should be much better now.

I also fixed an issue with coverage of multiple classes inside a single module / file.

And I've included my .editorconfig file.