massiveart / MassiveSearchBundle

MIT License
67 stars 24 forks source link

Add possibility to deindex object in specific locale #150

Closed luca-rath closed 4 years ago

luca-rath commented 4 years ago

@alexander-schranz Until now, when calling $searchManager->deindex($object), $object was being deindexed in all locales. I'm pretty sure that this is a bug, but can you verify that?

alexander-schranz commented 4 years ago

@luca-rath don't think its a bug. Looks for me its currently not implemented that you can only deindex a specific locale. I think we can not change the default behaviour as if you remove currently a entity and call deindex you expect that it is removed in all locales not only the locale you provided.

If we want to provide deindex by locale we would need to add it to the deindex function e.g.:

public function deindex($object, $locale = null)

For bc we can only be added to the SearchManager not Interface.

luca-rath commented 4 years ago

thanks 🙂